Skip to content

Add https://github.com/ESP32Async/ESPAsyncTCP #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

Add https://github.com/ESP32Async/ESPAsyncTCP #5802

merged 1 commit into from
Jan 20, 2025

Conversation

@mathieucarbou
Copy link
Contributor

@mathieucarbou mathieucarbou commented Jan 20, 2025

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jan 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/ESP32Async/ESPAsyncTCP:

Linting library in ESPAsyncTCP
INFO: No header file found matching library name (ESP_Async_TCP.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name ESP Async TCP contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in ESPAsyncTCP/examples/ClientServer/Client

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPAsyncTCP/examples/ClientServer/Server

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPAsyncTCP/examples/SyncClient

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot requested review from per1234 and removed request for per1234 January 20, 2025 20:48
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/ESP32Async/ESPAsyncTCP:

Linting library in ESPAsyncTCP
INFO: No header file found matching library name (ESP_Async_TCP.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name ESP Async TCP contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in ESPAsyncTCP/examples/ClientServer/Client

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPAsyncTCP/examples/ClientServer/Server

Linter results for project: no errors or warnings

-------------------

Linting sketch in ESPAsyncTCP/examples/SyncClient

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit 94d2a49 into arduino:main Jan 20, 2025
11 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/ESP32Async/ESPAsyncTCP/

github-actions bot pushed a commit that referenced this pull request Jan 20, 2025
@ArduinoBot
Add submission # 5802
4da5434 
#5802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

topic: submission Add library to the list

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mathieucarbou